Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINI-6324] Create interfaces to share Cookie info to MiniApp #271

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

rleojoseph
Copy link
Collaborator

Description

  • Created interfaces to support sharing cookie info when requested by MiniApp

Links

MINI-6324

Checklist

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.8% 14.8% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #271 (f22357d) into master (41fdc36) will decrease coverage by 0.94%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   82.83%   81.89%   -0.94%     
==========================================
  Files          24       25       +1     
  Lines         699      718      +19     
  Branches       53       53              
==========================================
+ Hits          579      588       +9     
- Misses        101      111      +10     
  Partials       19       19              
Files Coverage Δ
js-miniapp-sdk/src/miniapp.ts 93.93% <100.00%> (+0.18%) ⬆️
js-miniapp-sdk/src/modules/cookie-manager.ts 71.42% <71.42%> (ø)
js-miniapp-bridge/src/common-bridge.ts 72.56% <20.00%> (-1.97%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GondiTilak GondiTilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -25,7 +25,7 @@
"format": "prettier --config ./prettier.config.js --write 'src/**/*.js'",
"prettify": "prettier --config ./prettier.config.js --check src/**/*.js",
"lint": "eslint src/ --fix-dry-run",
"start": "react-scripts start",
"start": "react-scripts --openssl-legacy-provider start",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be remove this one! @rleojoseph

@rleojoseph rleojoseph merged commit c964195 into rakutentech:master Oct 13, 2023
8 checks passed
@rleojoseph rleojoseph deleted the feat/cookies branch October 13, 2023 06:36
rleojoseph added a commit that referenced this pull request Oct 16, 2023
rleojoseph added a commit that referenced this pull request Oct 16, 2023
@rleojoseph rleojoseph restored the feat/cookies branch October 18, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants