Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix character escaping #529

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

rleojoseph
Copy link
Collaborator

@rleojoseph rleojoseph commented Oct 16, 2023

Description

  • Several characters are not escaped properly. This will encode the string that will be sent to MiniApp (MiniApp Bridge will decode it)
    And we are encoding this only for miniappreceivejsoninfo not to break other things

Links

Add links to github/jira issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

  • I have read the contributing guidelines.
  • I have completed the SDK Development Learning Path (if submitting a feature PR)
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys
  • I ran fastlane ci without errors

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #529 (51a55b5) into master (9118a3a) will increase coverage by 0.08%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   78.86%   78.95%   +0.08%     
==========================================
  Files          88       88              
  Lines        6464     6472       +8     
  Branches     3047     3053       +6     
==========================================
+ Hits         5098     5110      +12     
+ Misses       1207     1201       -6     
- Partials      159      161       +2     
Files Coverage Δ
Sources/Classes/core/View/MiniAppViewHandler.swift 70.42% <77.77%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Climbatize Climbatize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

@Climbatize Climbatize merged commit 2fccc8b into rakutentech:master Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants