Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Improve loading time for load miniapp from bundle #528

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[iOS] Improve loading time for load miniapp from bundle #528

wants to merge 3 commits into from

Conversation

rleojoseph
Copy link
Collaborator

@rleojoseph rleojoseph commented Oct 5, 2023 •
edited
Loading

Description

Describe the changes in this pull request.
Explain your rationale of technical decisions you made (unless discussed before).

Links

Add links to github/jira issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

  • I have read the contributing guidelines.
  • I have completed the SDK Development Learning Path (if submitting a feature PR)
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys
  • I ran fastlane ci without errors

@rleojoseph rleojoseph added the SDK label Oct 5, 2023
@rleojoseph rleojoseph requested a review from a team as a code owner October 5, 2023 09:52
@rleojoseph rleojoseph self-assigned this Oct 5, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
35.5% 35.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GondiTilak GondiTilak GondiTilak approved these changes

@Climbatize Climbatize Awaiting requested review from Climbatize Climbatize is a code owner automatically assigned from rakutentech/miniapp-technology

@corycaywood corycaywood Awaiting requested review from corycaywood corycaywood is a code owner automatically assigned from rakutentech/miniapp-technology

@munir-rakuten munir-rakuten Awaiting requested review from munir-rakuten munir-rakuten is a code owner automatically assigned from rakutentech/miniapp-technology

@chethandevrak chethandevrak Awaiting requested review from chethandevrak chethandevrak is a code owner automatically assigned from rakutentech/miniapp-technology

At least 2 approving reviews are required to merge this pull request.

Assignees

@rleojoseph rleojoseph

Labels
SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rleojoseph @GondiTilak