Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINI-5899][iOS Sample] Enable deeplink/QR code to save the Project key and subscription key #527

Merged
merged 11 commits into from
Sep 1, 2023
Merged

[MINI-5899][iOS Sample] Enable deeplink/QR code to save the Project key and subscription key #527

merged 11 commits into from
Sep 1, 2023

Conversation

GondiTilak
Copy link
Contributor

Description

This PR is for Fixing issues identified by QA.

Links

MINI-5899

Checklist

  • I have read the contributing guidelines.
  • I have completed the SDK Development Learning Path (if submitting a feature PR)
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys
  • I ran fastlane ci without errors

GondiTilak and others added 8 commits July 19, 2023 17:55
@GondiTilak
[MINI-5899] [iOS] - Enable deeplinking to Save Project keys using QR
430ab89 
Enable passing the Project ID and subscription key using deep link.
For eg., miniappdemo://miniapp/settings?projectid=abc&subscription=def

**LINK**
[MINI-5899](https://jira.rakuten-it.com/jira/browse/MINI-5899)
@GondiTilak
[MINI-5899] [iOS] - Enable deeplinking to Save Project keys using QR
e3cf0d2 
Fix issue of keys not changing when switching List1-List2 in settings screen.

**LINK**
[MINI-5899](https://jira.rakuten-it.com/jira/browse/MINI-5899)
@GondiTilak
Merge branch 'master' into feat/MINI-5899-QRcodeSavingRASKeys
46e2da4
@GondiTilak
[MINI-5899] [iOS] - Enable deeplinking to Save Project keys using QR
e54f71e 
Fix swiftlint violations.

**LINK**
[MINI-5899](https://jira.rakuten-it.com/jira/browse/MINI-5899)
@rleojoseph
Merge branch 'master' into feat/MINI-5899-QRcodeSavingRASKeys
c4fa94a
@GondiTilak
Merge remote-tracking branch 'origin/master' into feat/MINI-5899-QRco…
c94d78e 
…deSavingRASKeys

* origin/master:
  [No Ticket] Post release change (rakutentech#524)
  Candidate merge for v5.3.1 (rakutentech#523)
  [MINI-5899][iOS Sample] Enable deeplink/QR code to save the Project key and subscription key (rakutentech#516)
@GondiTilak
Merge remote-tracking branch 'origin/master' into feat/MINI-5899-QRco…
add5e6c 
…deSavingRASKeys

* origin/master:
  [MINI-6258]Download Miniapp (rakutentech#525)
@GondiTilak
[MINI-5899] [iOS] - Enable deeplinking to Save Project keys using QR
815a9ab 
Fix issues identified by QA.

**LINK**
[MINI-5899](https://jira.rakuten-it.com/jira/browse/MINI-5899)
@GondiTilak GondiTilak added bug-fix Tag it if there is some bug fix introduced sample-app 5.3.0 labels Aug 31, 2023
@GondiTilak GondiTilak requested a review from a team as a code owner August 31, 2023 05:41
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #527 (bc12cdf) into master (d5440fe) will decrease coverage by 0.88%.
Report is 2 commits behind head on master.
The diff coverage is 9.19%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   79.82%   78.94%   -0.88%     
==========================================
  Files          88       88              
  Lines        6393     6464      +71     
  Branches     3004     3047      +43     
==========================================
  Hits         5103     5103              
- Misses       1131     1202      +71     
  Partials      159      159
Files Changed Coverage Δ
Sources/Classes/core/RealMiniApp.swift 75.66% <0.00%> (-3.07%) ⬇️
Sources/Classes/core/View/MiniAppView.swift 66.30% <0.00%> (-3.41%) ⬇️
...es/Classes/core/Downloader/MiniAppDownloader.swift 77.40% <4.54%> (-7.09%) ⬇️
...ces/Classes/core/Utilities/MiniAppSDKUtility.swift 21.21% <8.69%> (-45.46%) ⬇️
Sources/Classes/core/View/MiniAppViewHandler.swift 70.37% <22.22%> (-0.09%) ⬇️
Sources/Classes/core/MiniApp.swift 77.77% <37.50%> (-5.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GondiTilak @rleojoseph
Update Example/Controllers/SwiftUI/MiniAppDashboardView.swift
6384fd3 
Commit for suggested changes.

Co-authored-by: leojoseph.r <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

munir-rakuten
munir-rakuten approved these changes Sep 1, 2023
View reviewed changes
Copy link

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GondiTilak GondiTilak merged commit 9118a3a into rakutentech:master Sep 1, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munir-rakuten munir-rakuten munir-rakuten approved these changes

@rleojoseph rleojoseph rleojoseph approved these changes

@Climbatize Climbatize Awaiting requested review from Climbatize Climbatize is a code owner automatically assigned from rakutentech/miniapp-technology

@corycaywood corycaywood Awaiting requested review from corycaywood corycaywood is a code owner automatically assigned from rakutentech/miniapp-technology

Assignees
No one assigned
Labels
5.3.0 bug-fix Tag it if there is some bug fix introduced sample-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GondiTilak @rleojoseph @munir-rakuten