Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate v5.4.0 #526

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Candidate v5.4.0 #526

merged 7 commits into from
Sep 1, 2023

Conversation

rleojoseph
Copy link
Collaborator

@rleojoseph rleojoseph commented Aug 28, 2023

Description

PR after release

Checklist

  • I have read the contributing guidelines.
  • I have completed the SDK Development Learning Path (if submitting a feature PR)
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys
  • I ran fastlane ci without errors

rleojoseph and others added 7 commits August 1, 2023 12:25
* Hotfix release changes

* Swiftlint fix

* Swiftlint

* Swiftlint

* Update Sources/Classes/core/View/MiniAppView.swift

Co-authored-by: pierremichel.villa <[email protected]>

---------

Co-authored-by: pierremichel.villa <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #526 (8f94535) into master (d5440fe) will decrease coverage by 0.96%.
Report is 1 commits behind head on master.
The diff coverage is 9.19%.

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   79.82%   78.86%   -0.96%     
==========================================
  Files          88       88              
  Lines        6393     6464      +71     
  Branches     3004     3047      +43     
==========================================
- Hits         5103     5098       -5     
- Misses       1131     1207      +76     
  Partials      159      159              
Files Changed Coverage Δ
Sources/Classes/core/RealMiniApp.swift 75.66% <0.00%> (-3.07%) ⬇️
Sources/Classes/core/View/MiniAppView.swift 66.30% <0.00%> (-3.41%) ⬇️
...es/Classes/core/Downloader/MiniAppDownloader.swift 75.00% <4.54%> (-9.50%) ⬇️
...ces/Classes/core/Utilities/MiniAppSDKUtility.swift 21.21% <8.69%> (-45.46%) ⬇️
Sources/Classes/core/View/MiniAppViewHandler.swift 70.37% <22.22%> (-0.09%) ⬇️
Sources/Classes/core/MiniApp.swift 77.77% <37.50%> (-5.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GondiTilak GondiTilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rleojoseph rleojoseph merged commit 0ccf59a into master Sep 1, 2023
6 of 9 checks passed
@rleojoseph rleojoseph deleted the candidate branch October 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants