[WIP] Feat: Support for adding Custom Domains with railway domain [domain] [-p | --port]
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexng353
force-pushed
the
alex/add-custom-domains
branch
from
e5322ed to
7a58067
Compare
brody192
changed the title
alexng353
changed the title
railway domain [domain]
Milo123459
reviewed
Nov 5, 2024
wip: custom domains feat: interactive custom domain creation chore: remove gql.json chore: remove testing file
chore: remove regex to check if domain is valid - use the backend instead
alexng353
force-pushed
the
alex/add-custom-domains
branch
from
af19202 to
6b3b14b
Compare
coffee-cup
approved these changes
Nov 18, 2024
alexng353
changed the title
railway domain [domain]railway domain [domain] [-p | --port port]
alexng353
changed the title
railway domain [domain] [-p | --port port]railway domain [domain] [-p | --port]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
railway domain [domain] [-p | --port]Also can run interactively. Currently am unsure if it will work headless, but willing to test if that's necessary for this feature.The command runs entirely headlessly. If you are creating a custom domain in headless mode, I would recommend using the
--jsonflag to get a clean JSON output of the DNS records.Note: I updated the GQL schema using the method provided in CONTRIBUTING.md, which can be reverted if the admin deems it necessary (for whatever reason).
Docs PR: railwayapp/docs#613
Fixes: #512