Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on mutex_m #703

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Drop dependency on mutex_m #703

merged 1 commit into from
Nov 14, 2023

Conversation

byroot
Copy link
Member

@byroot byroot commented Nov 14, 2023

It doesn't really save much effort, and it's being extracted as a gem which cause issues for projects like spring that often are loaded before bundler.

Reported by @tisba

It doesn't really save much effort, and it's being
extracted as a gem which cause issues for projects
like spring that often are loaded before bundler.
@byroot byroot merged commit f7e452e into main Nov 14, 2023
22 of 32 checks passed
@tisba
Copy link

tisba commented Nov 14, 2023

Awesome turnaround time, thanks a lot @byroot! 🥳

@fschwahn
Copy link

@byroot This breaks eg. spring-watcher-listen (see rails/spring-watcher-listen#36), as it depends on the synchronize method. Possibly there are other dependencies affected by this.

Maybe instead of patching all dependencies which depend on this synchronize method could be added back to Abstract?

def synchronize(&block)
  @mutex.synchronize(&block(
end

@byroot
Copy link
Member Author

byroot commented Nov 22, 2023

Thanks for the ping.

@fschwahn
Copy link

Thank you for the quick turnaround 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants