Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Widget: File Navigator #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Rooyca
Copy link
Contributor

@Rooyca Rooyca commented May 20, 2024

This PR seeks to implement what was proposed in #22

One minor bug I encounter when testing was that when using the widget view it'll give a default value of 24h. I think has something to do with the format flag been use for clock and navigator. Here is a screenshot:

this

Other than that the widget should work as intended.

@rafaelveiga
Copy link
Owner

Hey @Rooyca! Thanks again for the contribution and sorry for the delay. A few things about this widget that I'm thinking:

  • I don't think we should add support for it on the Widget Config View, since this would me mostly used on files and not as a separate view
  • There is a bug on the Widget component src/NoteNavigator/index.tsx, where we are setting the path variable with two slashes. The + "/" at the end is causing it. This causes the file to be created every single time, instead of opening an existing one. This brings me to my next point:
  • I am not sure how people store their daily notes.
    • Some store all in a single folder with the YYYY-MM-DD format, which would be the perfect scenario for this widget, since we are basing the path to open on the path of the open file.
    • I think most use-cases store them separately in a month folder, separated by year, etc. So we would encounter 11-November/2024-11-30 in one day and 12-December/2024-12-01 in the other, making it difficult to auto-generate the link for the navigator

I'm still not sure on how we might solve this. I will ask around in the obsidian discord on how people store their daily notes and see if any idea pops up. If you have a solution, please let me know.

For now, I'm going to keep this PR open until we find a solution for those cases.

@rafaelveiga
Copy link
Owner

Asked around in discord and got some pretty interesting responses: https://discordapp.com/channels/686053708261228577/710585052769157141/1315149139142512761

@rafaelveiga
Copy link
Owner

Got a great suggestion from one of the members of the Discord on how to develop this https://discordapp.com/channels/686053708261228577/840286264964022302/1315157620662992907

@rafaelveiga
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants