collected maintenance changes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote from issue rafaelsteil#15: > libcgi contains an implementation of the md5 hash function, however > its not used inside the library itself and the status regarding > license or potential security issues (despite the weekness of md5 > itself) is not clear. If a user needs md5 he or she could get it from > a specialized library. Although md5 is deprecated (rafaelsteil#15) we can not simply remove the code from the API. Do that later. The HAVE_MD5 macro is useless, that was a relict from the old autotools build and actually meant »build with md5«, so we can simply drop the build time generated file and that macro. Fixes: 0643151 Signed-off-by: Alexander Dahl <[email protected]>
Straight forward string output of the current library version. Signed-off-by: Alexander Dahl <[email protected]>
When compiling with RelWithDebInfo gcc warned about out of bounds array access. The line removed now tried to ensure the string is null-terminated, but _after_ the actual array. The for loop initializing the array however uses integer overflow and str[255] will contain the necessary zero byte. Otherwise the strlen() check would fail anyway. While at it set two compile definitions needed for this test exutable. Signed-off-by: Alexander Dahl <[email protected]>
This way the include paths inside the project are similar to the ones a user would use, and building examples with CMake from inside this projects will be possible, if that is desired in the future. Signed-off-by: Alexander Dahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are collected changes, which should go in before releasing v1.2.0:
md5()function. This was basically broken in v1.1 and should be removed later. See remove md5 #15 for details.cgi_version()for convenience. Even if nobody uses it directly, it puts a version string into the binary one could extract withstrings…