Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish early strategy #3

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

CyonAlexRDX
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.2%. Comparing base (8d9418b) to head (046847b).
Report is 5 commits behind head on migrate_from_other_repo.

Files Patch % Lines
src/signing/collector/signatures_collector.rs 95.2% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           migrate_from_other_repo      #3     +/-   ##
=========================================================
- Coverage                     97.3%   97.2%   -0.1%     
=========================================================
  Files                           36      37      +1     
  Lines                          933     950     +17     
=========================================================
+ Hits                           908     924     +16     
- Misses                          25      26      +1     
Files Coverage Δ
...ing/collector/signatures_collector_dependencies.rs 100.0% <ø> (ø)
...signing/collector/signing_finish_early_strategy.rs 100.0% <100.0%> (ø)
src/signing/petition_types/petition_entity.rs 94.4% <ø> (-0.3%) ⬇️
src/signing/petition_types/petitions.rs 100.0% <100.0%> (ø)
src/signing/collector/signatures_collector.rs 98.2% <95.2%> (-0.8%) ⬇️

@CyonAlexRDX CyonAlexRDX merged commit 1d0e142 into migrate_from_other_repo Aug 28, 2024
5 of 6 checks passed
@CyonAlexRDX CyonAlexRDX deleted the finish_early_strategy branch August 28, 2024 10:27
CyonAlexRDX pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants