Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates #24

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Templates #24

merged 5 commits into from
Nov 30, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

No description provided.

Self { kind, id }
}

pub fn device(id: u8) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ever use two?

Self::new(FactorSourceKind::TrustedContact, id)
}

pub fn security_questions(id: u8) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont use two!

Self::new(FactorSourceKind::Device, id)
}

pub fn ledger(id: u8) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use ledger and ledger_other :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge arculus and ledger into a new proto-type. Hardware?

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 97.64151% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.1%. Comparing base (0c5f86f) to head (2e9ce67).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ates/rules/src/matrices/builder/matrix_template.rs 96.8% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #24     +/-   ##
=======================================
- Coverage   93.8%   93.1%   -0.7%     
=======================================
  Files         24      26      +2     
  Lines        938     925     -13     
=======================================
- Hits         880     862     -18     
- Misses        58      63      +5     
Files with missing lines Coverage Δ
.../rules/src/matrices/matrix_of_factor_source_ids.rs 100.0% <100.0%> (ø)
...r_levels/factor_source_kind_level/role_template.rs 100.0% <100.0%> (ø)
...factors/security_structure_of_factor_source_ids.rs 100.0% <ø> (ø)
...ates/rules/src/matrices/builder/matrix_template.rs 96.8% <96.8%> (ø)

@CyonAlexRDX CyonAlexRDX merged commit bc838e2 into main Nov 30, 2024
4 checks passed
@CyonAlexRDX CyonAlexRDX deleted the templates branch November 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants