-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates #24
Templates #24
Conversation
Self { kind, id } | ||
} | ||
|
||
pub fn device(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ever use two?
Self::new(FactorSourceKind::TrustedContact, id) | ||
} | ||
|
||
pub fn security_questions(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont use two!
Self::new(FactorSourceKind::Device, id) | ||
} | ||
|
||
pub fn ledger(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets use ledger
and ledger_other
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge arculus
and ledger
into a new proto-type. Hardware
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
- Coverage 93.8% 93.1% -0.7%
=======================================
Files 24 26 +2
Lines 938 925 -13
=======================================
- Hits 880 862 -18
- Misses 58 63 +5
|
No description provided.