Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const role #23

Merged
merged 13 commits into from
Nov 29, 2024
Merged

Const role #23

merged 13 commits into from
Nov 29, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 85.77778% with 32 lines in your changes missing coverage. Please review.

Project coverage is 84.6%. Comparing base (fe763b8) to head (bc64b75).
Report is 14 commits behind head on rules.

Files with missing lines Patch % Lines
crates/rules/src/roles/builder/roles_builder.rs 72.1% 17 Missing ⚠️
...ith_hierarchical_deterministic_factor_instances.rs 79.6% 11 Missing ⚠️
...ates/rules/src/roles/role_with_factor_instances.rs 86.9% 3 Missing ⚠️
.../rules/src/roles/abstract_role_builder_or_built.rs 88.8% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           rules     #23     +/-   ##
=======================================
+ Coverage   80.0%   84.6%   +4.5%     
=======================================
  Files         17      17             
  Lines        668     696     +28     
=======================================
+ Hits         535     589     +54     
+ Misses       133     107     -26     
Files with missing lines Coverage Δ
...s/src/matrices/abstract_matrix_builder_or_built.rs 100.0% <100.0%> (+100.0%) ⬆️
...rates/rules/src/matrices/builder/matrix_builder.rs 100.0% <100.0%> (ø)
...s/rules/src/matrices/matrix_of_factor_instances.rs 100.0% <100.0%> (+60.7%) ⬆️
.../rules/src/matrices/matrix_of_factor_source_ids.rs 100.0% <100.0%> (ø)
...tes/rules/src/matrices/matrix_of_factor_sources.rs 100.0% <100.0%> (ø)
crates/rules/src/roles/roles_with_factor_ids.rs 100.0% <100.0%> (ø)
...rates/rules/src/roles/roles_with_factor_sources.rs 97.3% <100.0%> (-2.7%) ⬇️
..._factors/abstract_security_structure_of_factors.rs 100.0% <ø> (ø)
...factors/security_structure_of_factor_source_ids.rs 100.0% <ø> (ø)
.../rules/src/roles/abstract_role_builder_or_built.rs 93.0% <88.8%> (+8.9%) ⬆️
... and 3 more

... and 1 file with indirect coverage changes

}
// impl HasSampleValues for RoleWithFactorSources {
// fn sample() -> Self {
// let ids = RoleWithFactorSourceIds::sample();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re

@@ -1,3 +1,6 @@
#![allow(incomplete_features)]
#![feature(inherent_associated_types)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed really


// #[test]
// fn assert_json_sample_recovery() {
// let sut = SUT::sample_recovery();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re

@CyonAlexRDX CyonAlexRDX merged commit 168f63a into rules Nov 29, 2024
4 checks passed
@CyonAlexRDX CyonAlexRDX deleted the const_role branch November 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants