Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor instances provider simplified by sketch in pr description #19

Conversation

CyonAlexRDX
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 94.03670% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.4%. Comparing base (8136341) to head (e8736e4).
Report is 26 commits behind head on factor_instances_provider.

Files with missing lines Patch % Lines
...ces_provider/provider/factor_instances_provider.rs 91.5% 7 Missing ⚠️
...tances_provider/provider/factor_instances_cache.rs 95.9% 4 Missing ⚠️
..._assigner/next_derivation_entity_index_assigner.rs 75.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           factor_instances_provider     #19     +/-   ##
===========================================================
- Coverage                       97.0%   96.4%   -0.6%     
===========================================================
  Files                             72      72             
  Lines                           1843    1818     -25     
===========================================================
- Hits                            1788    1754     -34     
- Misses                            55      64      +9     
Files with missing lines Coverage Δ
...ances_provider/agnostic_paths/derivation_preset.rs 100.0% <ø> (ø)
...ces_provider/agnostic_paths/index_agnostic_path.rs 95.4% <100.0%> (+0.2%) ⬆️
...erivation_entity_index_cache_analyzing_assigner.rs 100.0% <100.0%> (ø)
...ivation_entity_index_profile_analyzing_assigner.rs 100.0% <100.0%> (ø)
src/types/new_types/appendable_collection.rs 100.0% <100.0%> (ø)
src/types/new_types/factor_instances.rs 100.0% <ø> (+12.1%) ⬆️
src/types/new_types/key_space.rs 80.0% <100.0%> (+80.0%) ⬆️
..._assigner/next_derivation_entity_index_assigner.rs 87.5% <75.0%> (-5.4%) ⬇️
...tances_provider/provider/factor_instances_cache.rs 96.8% <95.9%> (-3.3%) ⬇️
...ces_provider/provider/factor_instances_provider.rs 84.1% <91.5%> (-9.8%) ⬇️

@CyonAlexRDX CyonAlexRDX merged commit 4ac0467 into factor_instances_provider Oct 12, 2024
5 of 6 checks passed
@CyonAlexRDX CyonAlexRDX deleted the factor_instances_provider_simplified_by_sketch_in_pr_description branch October 12, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants