Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor instances provider #15

Closed
wants to merge 76 commits into from

WIP

e4207c9
Select commit
Loading
Failed to load commit list.
Closed

Factor instances provider #15

WIP
e4207c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 30, 2024 in 1s

93.9% (-2.2%) compared to c7839f4

View this Pull Request on Codecov

93.9% (-2.2%) compared to c7839f4

Details

Codecov Report

Attention: Patch coverage is 88.73435% with 81 lines in your changes missing coverage. Please review.

Project coverage is 93.9%. Comparing base (c7839f4) to head (e4207c9).

Files with missing lines Patch % Lines
...c/pre_derived_keys_cache/pre_derived_keys_cache.rs 81.0% 19 Missing ⚠️
...s_provider/factor_instances_provider_operations.rs 60.6% 13 Missing ⚠️
...stances_provider/next_derivation_index_analyzer.rs 82.0% 9 Missing ⚠️
...ances_provider/factor_instances_request_purpose.rs 87.8% 8 Missing ⚠️
...covery_securify_cache/helpers/securified_entity.rs 66.6% 6 Missing ⚠️
...curify_cache/helpers/unindex_derivation_request.rs 88.8% 6 Missing ⚠️
src/pre_derived_keys_cache/cache_outcome.rs 84.3% 5 Missing ⚠️
...or_instances_provider/factor_instances_provider.rs 96.7% 4 Missing ⚠️
.../factor_instances_provider/split_cache_response.rs 83.3% 4 Missing ⚠️
src/factor_instances_provider/derive_more.rs 72.7% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #15     +/-   ##
=======================================
- Coverage   96.1%   93.9%   -2.2%     
=======================================
  Files         49      70     +21     
  Lines       1136    1843    +707     
=======================================
+ Hits        1092    1732    +640     
- Misses        44     111     +67
Files with missing lines Coverage Δ
src/derivation/collector/key_derivation_outcome.rs 100.0% <100.0%> (ø)
src/derivation/collector/key_ring.rs 100.0% <100.0%> (ø)
src/derivation/collector/keys_collector.rs 96.9% <100.0%> (+0.1%) ⬆️
src/derivation/collector/keys_collector_state.rs 100.0% <100.0%> (ø)
src/factor_instances_provider/newly_derived.rs 100.0% <100.0%> (ø)
src/recovery_securify_cache/helpers/accounts.rs 100.0% <100.0%> (ø)
...ify_cache/helpers/any_factor_derivation_request.rs 100.0% <100.0%> (ø)
...ecovery_securify_cache/helpers/factor_instances.rs 100.0% <100.0%> (ø)
...fy_cache/helpers/probably_free_factor_instances.rs 100.0% <100.0%> (ø)
...overy_securify_cache/helpers/securified_account.rs 100.0% <100.0%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

View more details on Codecov