fix: wait for onRemoteDescriptionSuccess before adding ice candidates

radixdlt · Jan 26, 2024 · c712a03 · c712a03
1 parent 7bd42d2
commit c712a03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/src/connector/webrtc/ice-candidate-client.ts b/src/connector/webrtc/ice-candidate-client.ts
@@ -77,18 +77,10 @@ export const IceCandidateClient = (input: {
     ),
   )
 
-  const haveLocalOffer$ = subjects.onSignalingStateChangeSubject.pipe(
-    filter((value) => value === 'have-local-offer'),
-  )
-
-  const haveRemoteOffer$ = subjects.onSignalingStateChangeSubject.pipe(
-    filter((value) => value === 'have-remote-offer'),
-  )
-  const waitForRemoteDescription$ = merge(
-    haveLocalOffer$,
-    haveRemoteOffer$,
-    subjects.onRemoteAnswerSubject,
-  )
+  const onRemoteDescriptionSuccess$ =
+    subjects.onRemoteDescriptionSuccessSubject.pipe(
+      filter((isSuccess) => isSuccess),
+    )
 
   const onRemoteIceCandidate$ = merge(
     subjects.remoteIceCandidatesSubject.pipe(
@@ -110,7 +102,7 @@ export const IceCandidateClient = (input: {
   )
 
   subscriptions.add(
-    waitForRemoteDescription$
+    onRemoteDescriptionSuccess$
       .pipe(
         mergeMap(() => onRemoteIceCandidate$),
         concatMap(addIceCandidate),

diff --git a/src/connector/webrtc/subjects.ts b/src/connector/webrtc/subjects.ts
@@ -20,4 +20,5 @@ export const WebRtcSubjects = () => ({
   onSignalingStateChangeSubject: new Subject<RTCSignalingState>(),
   dataChannelStatusSubject: new BehaviorSubject<'open' | 'closed'>('closed'),
   iceConnectionStateSubject: new Subject<RTCIceConnectionState>(),
+  onRemoteDescriptionSuccessSubject: new BehaviorSubject<boolean>(false),
 })