Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-2284 / add nodecli tests to nginx release workflow #47

Merged
23 commits merged into from
Mar 26, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2024

Contains:

  • add a copy of e2e tests from nodecli repo to this one
  • execute these tests on every PR pipeline run
  • overwrite version and release artifacts to use artifacts from this pipeline run

Concerns:

  • starts a webserver using an action from outside of our organisation
  • version of babylon-nodecli is hardcoded
  • copy of e2e tests is necessary because NGINX_REPO_OVERRIDE does not exist in babylon-nodecli yet
  • workflow dispatch was ruled out because nginx config would otherwise not be available

Copy link

Docker tags
docker.io/radixdlt/private-babylon-nginx:DO-2284-without-release
docker.io/radixdlt/private-babylon-nginx:development-latest

@ghost ghost changed the title Do 2284 without release DO-2284 / add nodecli tests to nginx release workflow Mar 26, 2024
@ghost ghost marked this pull request as ready for review March 26, 2024 09:15
tests/e2e-docker-nodecli.sh Outdated Show resolved Hide resolved
@ghost ghost merged commit d3de2b1 into main Mar 26, 2024
6 of 7 checks passed
@ghost ghost deleted the DO-2284-without-release branch March 26, 2024 15:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants