Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx stream resource balance change and transaction status filter #817

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

PawelPawelec-RDX
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 12, 2024

Docker tags
docker.io/radixdlt/private-babylon-ng-data-aggregator:HEAD-7c7bfb7-arm64

Copy link

github-actions bot commented Dec 12, 2024

Docker tags
docker.io/radixdlt/private-babylon-ng-database-migrations:HEAD-7c7bfb7-arm64

Copy link

github-actions bot commented Dec 12, 2024

Docker tags
docker.io/radixdlt/private-babylon-ng-gateway-api:HEAD-7c7bfb7-arm64

@PawelPawelec-RDX PawelPawelec-RDX force-pushed the tx-stream-resource-balance-change-filter branch from 5357748 to 1a16966 Compare December 12, 2024 12:51
CHANGELOG.md Outdated Show resolved Hide resolved
@@ -4357,6 +4357,19 @@ components:
type: array
items:
$ref: "#/components/schemas/Address"
balance_change_resources_filter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also tweak a few other places:

  • Could we add a description of these filters to the Supported filters section of the examples?
  • Could we update the manifest_resources_filter to recommend that integrators likely wish to use balance_change_resources_filter instead in most cases, as it also captures resource changes which aren't in the manifest.

@PawelPawelec-RDX PawelPawelec-RDX force-pushed the tx-stream-resource-balance-change-filter branch from a265070 to 57b601d Compare December 17, 2024 12:48
@PawelPawelec-RDX PawelPawelec-RDX merged commit 98ccd07 into develop Dec 17, 2024
16 of 17 checks passed
@PawelPawelec-RDX PawelPawelec-RDX deleted the tx-stream-resource-balance-change-filter branch December 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants