Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy < 2 #266

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Pin numpy < 2 #266

merged 1 commit into from
Jun 18, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Jun 17, 2024

At the moment, there are no available bitshuffle wheels built for numpy>=2. Also, our weighted_median module has some compatibility issues with numpy >= 2. For now I've just pinned numpy < 2 until I can figure out these incompatibilities

@ljgray ljgray force-pushed the ljg/build-bitshuffle branch 4 times, most recently from 6883b16 to 1c41ced Compare June 17, 2024 23:46
@ljgray ljgray force-pushed the ljg/build-bitshuffle branch from 1c41ced to 8ada6f5 Compare June 17, 2024 23:57
@ljgray ljgray changed the title fix(ci): build bitshuffle to avoid wheel incompatible with numpy >= 2 Pin numpy < 2 Jun 18, 2024
@ljgray ljgray marked this pull request as ready for review June 18, 2024 00:01
@ljgray ljgray requested a review from ketiltrout June 18, 2024 00:01
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prudent until we've fully investigated the impact of numpy-2.

@ljgray ljgray merged commit f6761b4 into master Jun 18, 2024
5 checks passed
@ljgray ljgray deleted the ljg/build-bitshuffle branch June 18, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants