Enforce linting rule RUF012 #259
Conversation
| e.__class__.__name__, | ||
| str(e), | ||
| ) | ||
| msg = f"Loading task '{task_path}' caused error {e.__class__.__name__}:\n\t{e!s}" |
There was a problem hiding this comment.
What's the reason for embedding e in the re-raised CaputConfigError here (I'm mostly talking about the \t{e!s} part)?
raise BarError from FooError is already going to report the original FooError in one of its two tracebacks.
And if something else is catching the CaputConfigError, isn't it better for that to get the original e out of CaputConfigError.__cause__ if it wants it?
There was a problem hiding this comment.
Honestly? I'm not sure. I think it was just written this way when the original pipeline runner was put together years and years ago.
I have another branch where I'm making improvements to the pipeline runner, so I'll make some error message improvements there instead so that this branch only makes style changes
See radiocosmology/draco#258