feat(CLI): "file find" command #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After "file list", this was less involved that I feared it would be. I think there's potential to add more ways of searching for files, but this is good for now. There are always going to be limits to how much selection can be done with the CLI. For very complex queries, users are going to have to access the ORM directly and make their own queries. This is the last command I wanted to implement from the command list. So, I'm going to say this closes #202, unless someone can come up with an argument to promote one of the proposed commands I suggested, which otherwise will get left on the back-burner. After all these command PRs are merged there is still going to be one or more clean-up passes to do on the CLI before I'm willing to leave it alone for the time-being.
ljgray
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After "file list", this was less involved that I feared it would be.
I think there's potential to add more ways of searching for files, but this is good for now. There are always going to be limits to how much selection can be done with the CLI. For very complex queries, users are going to have to access the ORM directly and make their own queries.
This is the last command I wanted to implement from the command list in #202, unless someone can come up with an argument to promote one of the proposed commands I suggested, which otherwise will get left on the back-burner.
After all these command PRs are merged there is still going to be one or more clean-up passes to do on the CLI before I'm willing to leave it alone for the time-being.
Closes #248