feat(CLI): StorageTransferAction support #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
Closed
ljgray
approved these changes
Nov 14, 2024
This is based on my suggestion to remove the `action` group in #202, which I think was ill-defined. Instead: * Adds an `--actions` flag to `node show` and `group show` to show relevant `StorageTransferAction`s affecting the node/group. * Adds an `--all` flag to `node show` and `group show` to provide a way to list everything without having to know what lists what. * Adds two new commands to manipulate `StorageTransferAction`s: * `group auto-sync GROUP NODE` to set/clear the autosync flag * `node auto-clean NODE GROUP` to set/clear the autoclean flag For a given (NODE, GROUP) pair, these two commands modify the same row in the `StorageTransferAction` table (the pair has to be unique in the table). So, there's ambiguity over which command goes with which "noun". The way I've done it, the command is associated with the object that the auto-action modifies (auto-sync adds files to GROUP; auto-clean deletes files from NODE). There's probably an argument for doing it the other way; I'm not sure it matters much, so long as we are consistent about it. Also: should the command names have a dash in them? Or would `group autosync GROUP NODE` etc. be better?
ketiltrout
force-pushed
the
client_transfer_actions
branch
from
c22981c to
1f66d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on my suggestion to remove the
actiongroup in #202, which I think was ill-defined.Instead:
--actionsflag tonode showandgroup showto show relevantStorageTransferActions affecting the node/group.--allflag tonode showandgroup showto provide a way to list everything without having to know what lists what.StorageTransferActions:group auto-sync GROUP NODEto set/clear the autosync flagnode auto-clean NODE GROUPto set/clear the autoclean flagFor a given (NODE, GROUP) pair, these two commands modify the same row in the
StorageTransferActiontable (the pair has to be unique in the table). So, there's ambiguity over which command goes with which "noun". The way I've done it, the command is associated with the object that the auto-action modifies (auto-sync adds files to GROUP; auto-clean deletes files from NODE). There's probably an argument for doing it the other way; I'm not sure it matters much, so long as we are consistent about it.Also: should the command names have a dash in them? Or would
group autosync GROUP NODEetc. be better?