-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nautobot interface sync #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition. I like how you added the get-ohm-creds placeholder as well. Brings up how we need to start defining those.
How does this reconcile against #66? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Few optional questions/suggestions inline
argo-workflows/nautobot-interface-sync/sensors/nautobot-interface-update-sensor-int-sync.yaml
Show resolved
Hide resolved
argo-workflows/nautobot-interface-sync/code/sync_nautobot_interfaces.py
Outdated
Show resolved
Hide resolved
argo-workflows/nautobot-interface-sync/code/sync_nautobot_interfaces.py
Outdated
Show resolved
Hide resolved
58dd652
to
ea4f6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes - found few more cosmetic issues, but otherwise it's good to go 🚀
ea4f6af
to
11672a5
Compare
The purpose of the workflow templates in this folder is to create or update device interfaces in Nautobot from Redfish info that we get from a device using OBM credentials.
Closes PUC-199