Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nautobot interface sync #78

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

mfencik
Copy link
Contributor

@mfencik mfencik commented May 4, 2024

The purpose of the workflow templates in this folder is to create or update device interfaces in Nautobot from Redfish info that we get from a device using OBM credentials.

Closes PUC-199

Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. I like how you added the get-ohm-creds placeholder as well. Brings up how we need to start defining those.

.github/workflows/build-container-images.yaml Outdated Show resolved Hide resolved
@cardoe
Copy link
Contributor

cardoe commented May 6, 2024

How does this reconcile against #66?

Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Few optional questions/suggestions inline

.github/workflows/build-container-images.yaml Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/helpers.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/helpers.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/helpers.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/helpers.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/docs/README.md Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/docs/README.md Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/models.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/models.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes - found few more cosmetic issues, but otherwise it's good to go 🚀

argo-workflows/nautobot-interface-sync/code/helpers.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/models.py Outdated Show resolved Hide resolved
argo-workflows/nautobot-interface-sync/code/models.py Outdated Show resolved Hide resolved
@mfencik mfencik merged commit 4265ac0 into rackerlabs:main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants