fix: dnsmasq: pin versions, switch to debian #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrobul
changed the title
cardoe
reviewed
Apr 23, 2024
skrobul
force-pushed
the
fix-dnsmasq-deps
branch
from
7bcddfb
to
03f22c8
Compare
skrobul
changed the title
Turns out Alpine project does not really follow semver and removes any outdated packages from their repositories as soon as the new versions are released. This results in a non-reproducible builds. See https://gitlab.alpinelinux.org/alpine/abuild/-/issues/9996 for more details. This commit switches the base image to a slimmed down version of Debian, which allows us to use more stable package versioning at the cost of increasing image size from ~75MB to ~120MB. Closes PUC-241.
skrobul
force-pushed
the
fix-dnsmasq-deps
branch
from
03f22c8
to
4d6fdc6
Compare
As discussed on Teams, Alpine does not offer any sensible way to pin the repository and retain old packages, so I have switched the dnsmasq container to use Debian base image. |
cardoe
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the Alpine project does not follow semver and changes the versioned upstream images after the fact, so we have to pin them to a specific sha256 to keep stable builds.
Closes PUC-241. Fixes build failures like this one