DO NOT MERGE WIP native Elixir #12922
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-native-elixir
branch
2 times, most recently
from
2659d40 to
727002a
Compare
It was only used in rabbitmq_prometheus, yet depended on by two other projects. It doesn't really provide much value.
lhoguin
force-pushed
the
loic-native-elixir
branch
from
727002a to
08d1e10
Compare
Taken from the module Elixir generates, but simplified.
|
This should not be merged before I am back from PTO but we are getting to a point where it can be tested as everything should work fine and tests are green. Mix remains used but only when testing rabbitmq_cli (I do not see much value in converting that part). With Mix removed this opens the way to moving to a proper apps/ structure and avoid going through all rabbit apps every time we compile but this will be done at a later time, priorities! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP