Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quorum queue tick handling: log stacktrace in case of an exception #10391

Draft
wants to merge 2 commits into
base: v3.12.x
Choose a base branch
from
Draft

Quorum queue tick handling: log stacktrace in case of an exception #10391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41936e2
Add stacktrace
lukebakken Jan 22, 2024
2ab889b
Fix formatter crash when Port is `undefined`
lukebakken Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/rabbit/src/rabbit_epmd_monitor.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ handle_port_please(init, noport, Me, Port) ->
rabbit_log:info("epmd does not know us, re-registering as ~ts", [Me]),
{ok, Port};
handle_port_please(check, noport, Me, Port) ->
rabbit_log:warning("epmd does not know us, re-registering ~ts at port ~b", [Me, Port]),
rabbit_log:warning("epmd does not know us, re-registering ~ts at port ~tp", [Me, Port]),
{ok, Port};
handle_port_please(_, closed, _Me, Port) ->
rabbit_log:error("epmd monitor failed to retrieve our port from epmd: closed"),
Expand Down
6 changes: 3 additions & 3 deletions deps/rabbit/src/rabbit_quorum_queue.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,9 @@ handle_tick(QName,
ok
end
catch
_:Err ->
rabbit_log:debug("~ts: handle tick failed with ~p",
[rabbit_misc:rs(QName), Err]),
Class:Error:Stacktrace ->
rabbit_log:debug("~ts: handle tick failed with ~tp:~tp:~tp",
[rabbit_misc:rs(QName), Class, Error, Stacktrace]),
ok
end
end).
Expand Down
Loading