-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rules_erlang 4.x #10374
Draft
HoloRin
wants to merge
26
commits into
main
Choose a base branch
from
use-rules_erlang-4.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use rules_erlang 4.x #10374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
use-rules_erlang-4.x
branch
6 times, most recently
from
March 4, 2024 13:38
d08a613
to
2e7d1d5
Compare
HoloRin
force-pushed
the
use-rules_erlang-4.x
branch
3 times, most recently
from
March 20, 2024 18:44
4690333
to
16d4dbf
Compare
This is probably incorrect, as oauth2_client does in fact depend on rabbit and rabbit_common. After this, the deps should probably corrected together for this app in both build systems
rules_docker depends on an old gazelle, which depends on an old rules_go, which is not bazel 7 compatible bazel-contrib/rules_go#3361 (comment) So we make the gazelle dependency explicit on a newer version
HoloRin
force-pushed
the
use-rules_erlang-4.x
branch
from
March 22, 2024 12:32
b56b190
to
5594620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary bazel file adjustments for rules_erlang 4.x