Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing simple errors #280

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Fixing simple errors #280

merged 3 commits into from
Aug 21, 2024

Conversation

korolev-d-l
Copy link
Contributor

  • Fixed channel max error message
  • Fixed example "set client connection name"

@michaelklishin
Copy link
Member

The golangci-lint failure is equally present in main and seems to be new (possibly due to a linter update?)

@korolev-d-l
Copy link
Contributor Author

The golangci-lint failure is equally present in main and seems to be new (possibly due to a linter update?)

Yes, my old version 1.59.1 dont showes error, but after update golangci-lint to 1.60.2 it showed

@michaelklishin
Copy link
Member

@Zerpet any objections to merging this?

Zerpet
Zerpet approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this PR.

@michaelklishin michaelklishin merged commit dc67c21 into rabbitmq:main Aug 21, 2024
7 checks passed
@korolev-d-l korolev-d-l deleted the fixing-simple-errors branch August 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korolev-d-l @michaelklishin @Zerpet