Small fixes and refactors #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge after CI passes |
…ing to []bytes explicitely
Zerpet
force-pushed
the
small-fixes-and-refactors
branch
from
62c1f6a
to
a212a69
Compare
|
@peczenyj I rebased update the PR using GitHub UI and it added me as committer to your commits. You are still the author. Are you ok to merge as-is? Or would you like to rebase yourself and force push? |
|
you can go ahead
Em qui., 6 de jun. de 2024 às 15:29, Aitor Pérez Cedres <
***@***.***> escreveu:
… @peczenyj <https://github.com/peczenyj> I rebased update the PR using
GitHub UI and it added me as committer to your commits. You are still the
author. Are you ok to merge as-is? Or would you like to rebase yourself and
force push?
—
Reply to this email directly, view it on GitHub
<#266 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOQLRNWVPQRNTX7Y3VGZTZGBP3RAVCNFSM6AAAAABIYSLQ7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSGUYDANBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Tiago B. Peczenyj
http://about.me/peczenyj
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some commits moved from PR #265