Undeprecate non-context publish functions #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
force-pushed
the
fix/update-context-docs
branch
from
5448f3b
to
66fb9da
Compare
The context was not honoured in any of the *WithContext functions. This is confusing, and arguably broken. However, we cannot immediately fix the context-support situation due to #124 (comment) This commit undeprecates the non-context variants of publish, and documents that both variants are equivalent. The example now favours the non-context variants. Related to #195 Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
fix/update-context-docs
branch
from
66fb9da
to
f786561
Compare
lukebakken
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context was not honoured in any of the *WithContext functions. This
is confusing, and arguably broken. However, we cannot immediately fix
the context-support situation due to #124 (comment)
This commit undeprecates the non-context variants of publish, and
documents that both variants are equivalent. The example now favours the
non-context variants.
Fixes #195