Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes 222 #223

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Closes 222 #223

merged 3 commits into from
Sep 28, 2023

Conversation

yywing
Copy link
Contributor

@yywing yywing commented Sep 27, 2023 •
edited by michaelklishin
Loading

Closes #222

@yywing yywing changed the title Issue 222 WIP: Issue 222 Sep 27, 2023
@yywing yywing changed the title WIP: Issue 222 Issue 222 Sep 27, 2023
@yywing yywing mentioned this pull request Sep 27, 2023
Closed
@lukebakken lukebakken self-requested a review September 27, 2023 13:22
@lukebakken lukebakken added this to the 1.9.0 milestone Sep 27, 2023
@lukebakken lukebakken self-assigned this Sep 27, 2023
@michaelklishin michaelklishin changed the title Issue 222 Closes 222 Sep 27, 2023
@Zerpet Zerpet self-assigned this Sep 27, 2023
Zerpet
Zerpet reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I agree with most of the changes. See my comments below for outstanding issues.

connection.go Show resolved Hide resolved
connection.go Show resolved Hide resolved
@Zerpet Zerpet merged commit fbae907 into rabbitmq:main Sep 28, 2023
7 checks passed
@Zerpet
Copy link
Contributor

Zerpet commented Sep 28, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet left review comments

@lukebakken lukebakken Awaiting requested review from lukebakken

Assignees

@lukebakken lukebakken

@Zerpet Zerpet

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

connection block when write connection reset by peer
3 participants
@yywing @Zerpet @lukebakken