Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples and fix on errors online based in httr #70

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Examples and fix on errors online based in httr #70

merged 2 commits into from
Oct 25, 2023

Conversation

dieghernan
Copy link
Member

@dieghernan dieghernan commented Oct 24, 2023

See #69

skip_on_cran()
skip_if_gisco_offline()

# expect_silent(gisco_bulk_download(resolution = 60, cache_dir = tempdir()))

Check notice

Code scanning / lintr

Commented code should be removed. Note test

Commented code should be removed.
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (872373d) 97.43% compared to head (c92a8b9) 97.36%.
Report is 1 commits behind head on main.

❗ Current head c92a8b9 differs from pull request most recent head 0496bbc. Consider uploading reports for the commit 0496bbc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   97.43%   97.36%   -0.08%     
==========================================
  Files          17       17              
  Lines         859      873      +14     
==========================================
+ Hits          837      850      +13     
- Misses         22       23       +1     
Files Coverage Δ
R/gisco_get_airports.R 100.00% <ø> (ø)
R/gisco_get_healthcare.R 94.44% <100.00%> (-5.56%) ⬇️
R/utils_downloads.R 97.20% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dieghernan dieghernan merged commit b1bd6f4 into main Oct 25, 2023
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant