Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto exposure and autofocus not working properly. Issue 341 #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix auto exposure and autofocus not working properly. Issue 341 #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Library/Sources/SCRecorder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,17 @@ - (void)configureDevice:(AVCaptureDevice*)newDevice mediaType:(NSString*)mediaTy
if (newDevice.isSmoothAutoFocusSupported) {
newDevice.smoothAutoFocusEnabled = YES;
}
newDevice.subjectAreaChangeMonitoringEnabled = true;

if ([newDevice isFocusModeSupported:AVCaptureFocusModeAutoFocus]) {
newDevice.subjectAreaChangeMonitoringEnabled = true;
} else {
if ([newDevice isExposureModeSupported:AVCaptureExposureModeContinuousAutoExposure]) {
newDevice.exposureMode = AVCaptureExposureModeContinuousAutoExposure;
}
if ([newDevice isFocusModeSupported:AVCaptureFocusModeContinuousAutoFocus]) {
newDevice.exposureMode = AVCaptureFocusModeContinuousAutoFocus;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be newDevice.focusMode?

}
}

if (newDevice.isLowLightBoostSupported) {
newDevice.automaticallyEnablesLowLightBoostWhenAvailable = YES;
Expand Down