Fix for generating binary for App Store submission #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 22, 2016 12:50
…ld Phases -> Headers -> Items in Public moved to Project
… the beginning of each session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We added SCRecorder as a submodule to our project. Then, we archived and generated the final binary to be submitted to App Store. However, XCode did not allow this binary to be uploaded. After some research, we found that if we move the items in SCRecorder -> Build Phases -> Headers -> Public to Project, it works fine.
Is there any particular reason why those headers are in Public Headers? If not, it would be useful to make the pull request.