Orientation change #113
Open
Orientation change #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent changing video orientation to support exclusive orientations during 1 segment recording. In case that app could have different orientations supported we need to prevent changing video orientation to support exclusive orientations during 1 segment recording. Also reset it after pausing segment.
|
+1 for this as this would prevent Video Preview Layer from rotating when recorder is used in VC's locked to a particular orientation . But Instead of [self currentOrientationSupportedByApplication] I would have it ViewController specific. |
added 2 commits
April 5, 2015 21:58
Conflicts: Library/Sources/SCRecorder.m
rFlex
force-pushed
the
master
branch
2 times, most recently
from
79b318c
to
788a6cd
Compare
|
the same problem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that app could have different orientations supported we need to
prevent changing video orientation to support exclusive orientations
during 1 segment recording.
Also reset it after pausing segment.