Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve ux #235

Merged
merged 3 commits into from
Jul 3, 2024
Merged

refactor: improve ux #235

merged 3 commits into from
Jul 3, 2024

Conversation

evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented Jul 2, 2024

Reuse cli module functionality to standardise ux.

Reuse cli functionality to standardise ux.
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (9644bb4) to head (c2a631f).

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   70.03%   70.07%   +0.03%     
==========================================
  Files          44       44              
  Lines        6565     6562       -3     
  Branches     6565     6562       -3     
==========================================
  Hits         4598     4598              
+ Misses       1230     1225       -5     
- Partials      737      739       +2     
Files Coverage Δ
crates/pop-cli/src/commands/new/parachain.rs 45.39% <40.00%> (-0.52%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created and Issue to do this refactor for the rest of the commands: #236

@AlexD10S
Copy link
Collaborator

AlexD10S commented Jul 2, 2024

There are conflicts after merging #226

# Conflicts:
#	crates/pop-cli/src/commands/new/parachain.rs
@evilrobot-01
Copy link
Contributor Author

There are conflicts after merging #226

Updated.

@AlexD10S AlexD10S self-requested a review July 3, 2024 10:36
@AlexD10S AlexD10S merged commit b606c09 into main Jul 3, 2024
14 of 15 checks passed
@AlexD10S AlexD10S deleted the frank/ux branch July 3, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants