Skip to content

Commit

Permalink
Version 1.0.2 submission
Browse files Browse the repository at this point in the history
  • Loading branch information
csim063 committed Jul 7, 2021
1 parent d3f8d81 commit 2f365ce
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: spectre
Type: Package
Title: Predict Regional Community Composition
Version: 1.0.1
Version: 1.0.2
Authors@R: c(person("Craig", "Simpkins", email = "[email protected]", role = c("aut", "cre")),
person("Sebastian", "Hanss", role = c("aut")),
person("Maximilian", "Hesselbarth", role = c("aut")),
Expand All @@ -10,7 +10,7 @@ Authors@R: c(person("Craig", "Simpkins", email = "[email protected]", r
Maintainer: Craig Simpkins <[email protected]>
Description: Predict regional community composition at a fine spatial
resolution using only sparse biological and environmental data. The package
is based on the DynamicFOAM algorithm desscribed
is based on the DynamicFOAM algorithm described
in Mokany et al. (2011) <doi:10.1111/j.1461-0248.2011.01675.x>.
License: GPL-3
Depends:
Expand Down
41 changes: 41 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
# spectre 1.0.2

## Resubmission and update
This is a resubmission of the spectre package in an updated form. Below is a list of changes made to address each issues from the previous submission:

Issue 1: "memtest"
The problem occurred because at one point in the code only the upper triangular matrix was calculated, not the complete matrix. Since the diagonal and the lower triangular matrix have values of "NA", the unsigned integer overflowed.
The problem was solved in two places
- the lower triangular matrix and diagonal are now set in the constructor of the C++ class "NA" instead of in the R function.
- the loops in the C++ code iterate only over the upper triangular matrix instead of iterating over the complete matrix and skipping "NA".

We also added a new unit test for this issue.

# Issue 2: LTO
The problem occurred because we use the Catch2 framework with testthat to test the C++ code (https://github.com/r-lib/testthat/issues/1230). This was fixed as described in the issue by manually adjusting the RcppExports.cpp.

Beyond addressing these issues we have also removed the `gdm` package dependency by creating a .RDS file of data to be used in tests and vignettes.

We have retested the package as follows:

## Test environments
* Local
* macOS BigSur, R 4.0.5
* Windows 10 Home, R 4.0.3
* Ubuntu 20.04 LTS, R 4.0.5
* GitHub Actions
* windows-latest, R: 'release'
* macOS-latest, R: 'release'
* ubuntu-20.04, R: 'release'
* win-builder (release, devel)

## R CMD check results

0 errors | 0 warnings | 0 note

* This is an updated resubmission.

## Reverse dependencies
There are currently no reverse dependencies.
---

# spectre 1.0.1

## Resubmission
Expand Down

1 comment on commit 2f365ce

@bitbacchus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Spectre Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2f365ce Previous: b065984 Ratio
optimize 3 sites, 3 species 347.423 ns (± 41.1185) 1.12586 us (± 6.96905) 308.58

This comment was automatically generated by workflow using github-action-benchmark.

CC: @bitbacchus

Please sign in to comment.