Use CFtime in stars for time management of netCDF files #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR after updating code to address issues with #690. This PR has been synched with the main branch minutes ago.
I have made a few updates to the code after studying issues with the tests. There are changes in
dimensions.R
andaggregate.R
, compared to the changes in the previous PR.Please note that I had to downgrade the dependency on
sf
: version 1.0-19 is not installing from CRAN (for MacOS) and building locally is impossible because I do not have the GDAL dev environment locally. I do not think that there is any impact of that on this PR.Considering that there remain differences in the tests compared to the saved output, I have installed a clean version of the
stars
source from a zip file download from GitHub 2 days ago. Comparing tests output between that version and my PR reveals the following:gridtypes.R
,raster.R
,stars.R
have diffs not related to the PR.area.R
gives 15 warnings in both the PR code and the current main stars branch. Is area.Rout.save out of date with only 12 warnings?curvilinear.R
.dimensions.R
will always have some differences because there is code added to deal with CFtime specifics. Otherwise the differences have been resolved.mdim.R
The objects created are the same, there are only differences in the attributes which are related to the fact that a CFtime instance is used to represent time from the netCDF file when doing read_mdim().