draft bivariate moran hotspots #155

[rsbivand]

@JosiahParry Could you check please?

The function man page now has:

library(spdep)
columbus <- st_read(system.file("shapes/columbus.shp", package="spData"))
nb <- poly2nb(columbus)
listw <- nb2listw(nb)
set.seed(1)
(res <- localmoran_bv(columbus$CRIME, columbus$INC, listw, nsim = 499))
columbus$hs <- hotspot(res, Prname="Pr(folded) Sim", cutoff=0.05,
 quadrant.type="pysal", p.adjust="none")
if (require("tmap", quietly=TRUE)) {
  tm_shape(columbus) + tm_fill("hs")
}

With the latest spData release, columbus.gpkg is available, avoiding the warning from tmap. spData is changing to GPKG from SHP.

[rsbivand]

@JosiahParry any chance of a response? I'd like to submit to CRAN this week.

[JosiahParry]

Thanks for the bump @rsbivand! These changes look great! I think having the plot function in the help page will also be very helpful for users. I feel comfortable merging this in.