Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config on Windows when available. #2241

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

kalibera
Copy link
Contributor

This will use pkg-config to establish the libraries to link when pkg-config is available (which will soon be in Rtools). This should reduce the frequency of needed updates to linking when new features are linked/enabled in gdal.

@kadyb
Copy link
Contributor

kadyb commented Oct 19, 2023

@edzer, it may be worth waiting until the Rtools will be update, because GHA and R-Universe will stop working (see: rspatial/terra#1306).

@kalibera
Copy link
Contributor Author

Updated Rtools with pkg-config are already available at https://cran.r-project.org/bin/windows/Rtools/rtools43/rtools.html
Depending on which make your github actions use, you however may have to create a pkg-config.bat wrapper - more in https://cran.r-project.org/bin/windows/base/howto-R-devel.html, "Establishing the linking order in R packages via pkg-config". But, certainly, this is not urgent.

@edzer
Copy link
Member

edzer commented Mar 16, 2024

@kalibera would merging this prevent the error we now see on r-devel-windows?

@kalibera
Copy link
Contributor Author

@kalibera would merging this prevent the error we now see on r-devel-windows?

Yes

@edzer
Copy link
Member

edzer commented Mar 16, 2024

Thanks!

@edzer edzer merged commit 3fa6a6b into r-spatial:main Mar 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants