Fix .by
argument of summarise()
to work
#2222
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2207.
Probably not the best way, but I update
summarise.sf()
to allow for.by
arguments.The solution here is to store the row IDs of the original data in the
.rows
column bydplyr::summarise()
.The disadvantage of this solution is that a column named
.rows
will be overwritten if the user has used it.However, the column name
.rows
is not generally used,since it cannot be used in
tibble::tibble()
and as a grouping variable fordplyr::group_by()
.I also noticed that
summarise.sf()
has an argument of.dots
, probably past dplyr.Now I have left it as is, but should I change the documentation as well?