-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabor segment deduplication #797
Conversation
@Nomos11 Can you test if this works? |
so far it seems to give me an IndexError at |
It seems like the segment_lengths need to be adapted to throw out duplicates, which should be fixable relatively easily.
at the end of |
Does it work now? |
From looking at the code I am a bit confused - does cutting off the array choose the correct values? the segment_lengths can contain subsequent duplicate values, which are not thrown out here, giving the incorrect values to my understanding |
You are right. I did not think it through. |
@Nomos11 Should work now |
Should fix #795