Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ipynbname #101

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Drop ipynbname #101

merged 1 commit into from
Nov 6, 2024

Conversation

thangleiter
Copy link
Member

ipynbname is slow to find the running notebook. It seems easier to determine if we're in a notebook to check the environment variables.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.97%. Comparing base (37a0453) to head (d118ac1).

Files with missing lines Patch % Lines
filter_functions/util.py 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   98.01%   97.97%   -0.05%     
==========================================
  Files           9        9              
  Lines        2270     2272       +2     
  Branches      552      430     -122     
==========================================
+ Hits         2225     2226       +1     
- Misses         18       19       +1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thangleiter thangleiter merged commit f3de423 into master Nov 6, 2024
26 of 29 checks passed
@thangleiter thangleiter deleted the maint/drop_ipynbname_dependency branch November 6, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant