Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FadeIn/FadeOut #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FadeIn/FadeOut #74

wants to merge 1 commit into from

Conversation

lyuba
Copy link

@lyuba lyuba commented Jan 28, 2011

Suggested code from here is not working as expected:
https://github.com/quirkey/sammy/blob/master/lib/sammy.js#L1107

Added callback to fix.

@lyuba
Copy link
Author

lyuba commented Jan 28, 2011

Well, just realized that I will not work in a right way with the callback either and here is the case:

Somewhere in the root we have:
this.partial(...)
.then(function() {
//bind events
});

Events are not always binded correctly since then doesn't wait untill swap finishes it's fadeIns/fadeOuts.

Even worth situation happen with the renders happening in callbacks. For example,

this.partial("layout_view.ejs")
.render("content_view.ejs")
.appendTo($("#content"));

What happens here is that content view is not rendered since layout_view was rendered with an asynchronous function.

Is there any way to fix then to watch such cases? FadeIn/FadeOut is something really-really wanted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant