-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo #6
Open
a2ikm
wants to merge
2
commits into
main
Choose a base branch
from
demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2ikm
force-pushed
the
demo
branch
5 times, most recently
from
February 18, 2021 10:26
b73b867
to
0cebbdb
Compare
a2ikm
force-pushed
the
demo
branch
3 times, most recently
from
February 19, 2021 06:09
819575b
to
eafd4ae
Compare
GitHub Action status on 2438e92 generated by comment-failure-action build-test
|
fghaas
added a commit
to fghaas/cleura-docs
that referenced
this pull request
Aug 16, 2023
Without this change, when a PR results in a build failure, the onus is on the PR submitter to find the failed build, and the corresponding build log. That is somewhat tedious and not particularly intuituive. Instead, use a separate GitHub Action that posts a comment back to the PR thread, containing a direct link to the failed build log. This should hopefully make it easier for PR submitters to find out what exactly their submitted change breaks. Reference: quipper/comment-failure-action#6
fghaas
added a commit
to fghaas/cleura-docs
that referenced
this pull request
Aug 16, 2023
Without this change, when a PR results in a build failure, the onus is on the PR submitter to find the failed build, and the corresponding build log. That is somewhat tedious and not particularly intuituive. Instead, use a separate GitHub Action that posts a comment back to the PR thread, containing a direct link to the failed build log. This should hopefully make it easier for PR submitters to find out what exactly their submitted change breaks. References: https://github.com/quipper/comment-failure-action/ quipper/comment-failure-action#6
fghaas
added a commit
to fghaas/cleura-docs
that referenced
this pull request
Aug 16, 2023
Without this change, when a PR results in a build failure, the onus is on the PR submitter to find the failed build, and the corresponding build log. That is somewhat tedious and not particularly intuituive. Instead, use a separate GitHub Action that posts a comment back to the PR thread, containing a direct link to the failed build log. This should hopefully make it easier for PR submitters to find out what exactly their submitted change breaks. References: https://github.com/quipper/comment-failure-action/ quipper/comment-failure-action#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see, if a GitHub Action job fails in a pull request, this comment-failure-action adds a comment to tell what job failed.
You can see the workflow configuration at https://github.com/quipper/comment-failure-action/blob/demo/.github/workflows/demo.yml.