Allow fatal SBCL errors to be caught #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrologist
reviewed
Apr 8, 2024
kartik-s
force-pushed
the
catch-fatal-errors
branch
5 times, most recently
from
8d3f788 to
30991ab
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
4 times, most recently
from
656f7a8 to
c096346
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
c096346 to
551dae5
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
2 times, most recently
from
ff80900 to
bda3d3c
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
2 times, most recently
from
12567c1 to
6f4ba4d
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
6f4ba4d to
0381264
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
4 times, most recently
from
ba8ed32 to
757be44
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
6 times, most recently
from
744a0bb to
9a23881
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
7 times, most recently
from
c6eab0c to
0c46ced
Compare
|
This pr should gracefully handle calling into lisp after a fatal error. Doing so should repeat the fatal error behavior. |
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
0c46ced to
de02256
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
cd9c18e to
4981dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A call into Lisp may trigger a fatal error in SBCL, dropping the process unceremoniously into LDB and making it difficult for the user to gracefully terminate the process.
Solution
Use
setjmpto save the execution context before calling into Lisp, and uselongjmpto return to the pre-call execution context with a special error code if a fatal SBCL error was encountered.Notes
This feature requires patching SBCL to make thelossage_handlerfunction pointer non-static, settingsbcl-librarian::*non-static-lossage-handler*toT, and adding afatal-errorcode to the error map.set_lossage_handlerexists and is exported by the runtimeDEFINE-ERROR-TYPEtakes a newfatal-errorargument specifying which value to return when a Lisp call triggers a fatal SBCL error.setjmpbefore calling into Lisp through the associated function pointer.error-mapor nofatal-codeis specified, then the fatal error handler just drops into LDB.