chore(browser-tests): Refactor waiting for editor ready state #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to further reduce the possible flakiness on CI, which, although rare, sometimes manifests itself when the tests start to run before the editor is fully ready UI wise.
Changes:
window.editor_ready
global flag, which is set at the very end of the editor initialization process, when all the completion providers finish setup. This is in contrast to checking for meretextarea
presence, which can happen much earlier.waitForEditorLoad
Cypress command to use inbefore
andbeforeEach
hooks.cy.request()
instead of typing them manually in the editor - there is zero user value in the latter, and it significantly slows down the text execution time, as they are usually quite long.