-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): blocking LineSenderPool #53
Conversation
7317871
to
25482c0
Compare
@sklarsa I tried making the pool behave similarly to the "traditional" connection pools, i.e. you obtain a connection (sender in our case) with a call to the pool and then close the connection when you're done. Now it also blocks if there is already the maximum number of pooled senders. WDYT? |
This is very cool! Definitely more along the lines of how I originally envisioned the pool concept. |
@sklarsa thanks for the comprehensive review! |
Breaking change of an experimental API
The pool now blocks if there are already too many senders in use. Pooled senders are released implicitly, via the
Close
call.