Skip to content

Commit

Permalink
chore: move to move into for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
benfdking committed Oct 8, 2024
1 parent d418418 commit 2199e2a
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 16 deletions.
6 changes: 3 additions & 3 deletions crates/lib-dialects/src/ansi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ pub fn raw_dialect() -> Dialect {
dialect
.sets("bare_functions")
.into_iter()
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::BareFunction,
)
Expand Down Expand Up @@ -392,7 +392,7 @@ pub fn raw_dialect() -> Dialect {
dialect
.sets("datetime_units")
.into_iter()
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::DatePart,
)
Expand All @@ -407,7 +407,7 @@ pub fn raw_dialect() -> Dialect {
dialect
.sets("date_part_function_name")
.into_iter()
.map(Into::into)
.map_into()
.collect::<Vec<_>>(),
SyntaxKind::FunctionNameIdentifier,
)
Expand Down
2 changes: 1 addition & 1 deletion crates/lib-dialects/src/bigquery.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ pub fn dialect() -> Dialect {
dialect
.sets("extended_datetime_units")
.into_iter()
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::DatePart,
)
Expand Down
10 changes: 5 additions & 5 deletions crates/lib-dialects/src/snowflake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ pub fn dialect() -> Dialect {
.sets("warehouse_types")
.into_iter()
.filter(|it| !it.contains('-'))
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::WarehouseSize
),
Expand All @@ -295,7 +295,7 @@ pub fn dialect() -> Dialect {
.sets("warehouse_sizes")
.into_iter()
.filter(|it| !it.contains('-'))
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::WarehouseSize
),
Expand All @@ -318,7 +318,7 @@ pub fn dialect() -> Dialect {
snowflake_dialect
.sets("compression_types")
.into_iter()
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::CompressionType

Expand All @@ -343,7 +343,7 @@ pub fn dialect() -> Dialect {
.sets("warehouse_scaling_policies")
.into_iter()
.filter(|it| !it.contains('-'))
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::ScalingPolicy
),
Expand Down Expand Up @@ -485,7 +485,7 @@ pub fn dialect() -> Dialect {
.sets("file_types")
.into_iter()
.filter(|it| !it.contains('-'))
.map(Into::into)
.map_into()
.collect_vec(),
SyntaxKind::FileType
),
Expand Down
4 changes: 2 additions & 2 deletions crates/lib/src/core/linter/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ impl Linter {
initial_linting_errors
.unwrap_or_default()
.into_iter()
.map(Into::into),
.map_into(),
);

let linted_file = LintedFile {
Expand Down Expand Up @@ -397,7 +397,7 @@ impl Linter {
Some(rendered.filename.to_string()),
);
parsed = p;
violations.extend(pvs.into_iter().map(Into::into));
violations.extend(pvs.into_iter().map_into());
} else {
parsed = None;
};
Expand Down
6 changes: 1 addition & 5 deletions crates/lib/src/core/linter/linted_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ pub struct LintedFile {
impl LintedFile {
#[allow(unused_variables)]
pub fn get_violations(&self, fixable: Option<bool>) -> Vec<SQLBaseError> {
self.violations
.clone()
.into_iter()
.map(Into::into)
.collect_vec()
self.violations.clone().into_iter().map_into().collect_vec()
}

/// Use patches and raw file to fix the source file.
Expand Down

0 comments on commit 2199e2a

Please sign in to comment.