Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of the .class syntax for source code #842

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Sep 29, 2023

This follows questions on slack and issue on Quarto like quarto-dev/quarto-cli#7073

I believe this is worth documenting in Markdown basis that the long syntax with brackets can be necessary.

Possibly a callout to explain the different with computation code can be useful 🤔

@github-actions github-actions bot temporarily deployed to pull request September 29, 2023 12:36 Inactive
@cderv cderv marked this pull request as draft September 29, 2023 16:19
@cderv
Copy link
Collaborator Author

cderv commented Sep 29, 2023

I can't make the @sec- link working ... 😓 I need to look into that.

@cderv cderv self-assigned this Sep 29, 2023
@cwickham
Copy link
Collaborator

@cderv This has been sitting a while but I think it is an important addition. Is there anything else you wanted to add? If not, assign me as a reviewer and I'll do a wording review.

Also I think @sec syntax only works when sections are numbered, but maybe @cscheid has more input on that.

@github-actions github-actions bot temporarily deployed to pull request March 8, 2024 17:11 Inactive
@cderv cderv marked this pull request as ready for review March 8, 2024 17:11
@quarto-dev quarto-dev deleted a comment from github-actions bot Mar 8, 2024
@quarto-dev quarto-dev deleted a comment from github-actions bot Mar 8, 2024
@quarto-dev quarto-dev deleted a comment from github-actions bot Mar 8, 2024
@cderv cderv requested a review from cwickham March 8, 2024 17:14
@cderv
Copy link
Collaborator Author

cderv commented Mar 8, 2024

This is ready now.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

1 similar comment
Copy link
Contributor

github-actions bot commented Mar 8, 2024

@github-actions github-actions bot temporarily deployed to pull request March 8, 2024 17:18 Inactive
@cderv cderv assigned cwickham and unassigned cderv Mar 22, 2024
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 11:46 Inactive
@cderv
Copy link
Collaborator Author

cderv commented Mar 22, 2024

Is there anything else you wanted to add? If not, assign me as a reviewer and I'll do a wording review.

@cwickham I did not merge as it seems you wanted to review wording.

@cwickham
Copy link
Collaborator

Yes! I'll make a commit directly as my suggestion is a bit beyond GitHub's "suggestion" comment.

@cwickham
Copy link
Collaborator

Seems to be a bug that the cross-reference was showing a number instead of the section title. I switched to a link instead.

This looks good to merge to me!

Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 20:13 Inactive
@cderv
Copy link
Collaborator Author

cderv commented Mar 25, 2024

Thank you !

@cderv cderv merged commit 4e3e5ba into main Mar 25, 2024
3 checks passed
@cderv cderv deleted the source-code-attributes branch March 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants