Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confluence - fix characters being added to title when title is unique #9785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rossbowen
Copy link

When publishing to Confluence, the docs mention:

Quarto may add some additional characters to meet the Confluences requirement that every page in a space has a unique name.

I noticed that characters were being added even if there wasn't a page with the same title within my space. However, I noticed there were pages with the same title in other spaces. To me it looks like a small error in the way the CQL has been written, which this PR amends.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Did you test the change by any chance ? Does it solve it for you ?

This is very helping that you did not just opened an issue, but took the time to show change in PR. Thank you

src/publish/confluence/api/index.ts Show resolved Hide resolved
@rossbowen
Copy link
Author

rossbowen commented May 28, 2024

I did test but I will admit I got some errors - but different ones to the one which was above!

I took the failures to be a bit of a problem with my set up and a false positive... but all the confluence tests were passing. I'll give it another go locally!

Edit: looks like it's passing now; great! 🎉

@cderv
Copy link
Collaborator

cderv commented May 28, 2024

I'll give it another go locally!

If you can give me the step to test here, I can have a go on my side too, and add this to the manual testing we need to do.

@rossbowen
Copy link
Author

Apologies, I thought you meant running the Quarto tests!

I did a bit of manual testing with my Confluence setup, the process would be:

  • Create two spaces, A and B.
  • Create a document within space A with a title of "Hello world".
  • Attempt to quarto publish a document into space B with the title of "Hello world". It should publish without any additional characters being added to the title.
  • Attempt to quarto publish a document into space A with the title of "Hello world". It should publish with additional characters.

@cscheid cscheid added this to the v1.6 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants